Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replying large files #34

Closed
skerit opened this issue Dec 21, 2015 · 2 comments
Closed

Replying large files #34

skerit opened this issue Dec 21, 2015 · 2 comments

Comments

@skerit
Copy link

skerit commented Dec 21, 2015

I see you need to reply to read methods with a buffer containing all the data, won't that fail for files that are over 1.7GiB?

@EricTheMagician
Copy link
Collaborator

No it won't fail because the kernel never requests to read files that large at once.
The kernel will only request a small piece of that file to be read.
Once that chunk of file is read, the kernel will request another chunk.
At somepoint, the v8 garbage collector will kick in and clear out the unused buffers.

So, there shouldn't be a problem with this.
If there is, it's most likely at the user implementation level.

@skerit
Copy link
Author

skerit commented Dec 21, 2015

Oh, that's great.
Had no idea that's how it worked, but it makes sense of course.
Thanks for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants