Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-2578] Fix all unhandled errors in handleNewBooking flow. #11692

Closed
hariombalhara opened this issue Oct 4, 2023 · 0 comments
Closed

[CAL-2578] Fix all unhandled errors in handleNewBooking flow. #11692

hariombalhara opened this issue Oct 4, 2023 · 0 comments
Labels
🐛 bug Something isn't working Low priority Created by Linear-GitHub Sync

Comments

@hariombalhara
Copy link
Member

hariombalhara commented Oct 4, 2023

Fix all unhandled errors in handleNewBooking flow. Those errors cause a 500 and instead we should server a proper status code with a message.

e.g. When a user isn't available for a timeslot we throw error 'Some users are unavailable for booking', it should have been `throw new HttpError({statusCode: 400})

From SyncLinear.com | CAL-2578

@hariombalhara hariombalhara changed the title Fix all unhandled errors in handleNewBooking flow. [CAL-2578] Fix all unhandled errors in handleNewBooking flow. Oct 4, 2023
@maige-app maige-app bot added the 🐛 bug Something isn't working label Oct 4, 2023
@hariombalhara hariombalhara added this to the v3.4 milestone Oct 4, 2023
@keithwillcode keithwillcode modified the milestones: v3.4, v3.5 Oct 17, 2023
@keithwillcode keithwillcode added the Low priority Created by Linear-GitHub Sync label Nov 11, 2023
@keithwillcode keithwillcode removed this from the v3.5 milestone Nov 11, 2023
@hariombalhara hariombalhara modified the milestones: v.3, v3.4 Nov 11, 2023
@keithwillcode keithwillcode modified the milestones: v3.4, v3.6 Nov 16, 2023
@hariombalhara hariombalhara removed this from the v3.6 milestone Dec 18, 2023
@hariombalhara hariombalhara closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants