Skip to content

Commit 65ab921

Browse files
committed
Merged PR 56880: Tooltip X button fix and Duplicate identifier 'msCrypto' fix
Tooltip X button fix
1 parent d509acc commit 65ab921

File tree

6 files changed

+12
-16
lines changed

6 files changed

+12
-16
lines changed

demo/v2-demo/live_showcases/insight_to_action/showcase_insight_to_action.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div id="startTooltip">
2-
<div class="btnCloseTooltip" onclick="onTootipClicked('startTooltip');">
2+
<div class="btnCloseTooltip" onclick="onTootipClicked('closeTooltip');">
33
<img src="images\closeWhite.png"/>
44
</div>
55
<div class="showcaseTooltipText">Start a campaign with these customers</div>

demo/v2-demo/live_showcases/insight_to_action/showcase_insight_to_action.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,9 @@ function filterTable(filterValues, table) {
205205

206206
// Handles tooltip click action
207207
function onTootipClicked(tooltipId) {
208-
if (!InsightToActionShowcaseState.tooltipNextPressed && tooltipId === "startTooltip") {
208+
if ( tooltipId === "closeTooltip"){
209+
$('#startTooltip').hide();
210+
} else if (!InsightToActionShowcaseState.tooltipNextPressed && tooltipId === "startTooltip") {
209211
let newText = document.createTextNode("Then, click `Start campaign` menu command.");
210212
let startTooltipSubText = $('#startTooltip .showcaseTooltipSubText');
211213
const textOldHeight = startTooltipSubText[0].offsetHeight;

dist/powerbi-client.d.ts

-5
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
/*! powerbi-client v2.10.2 | (c) 2016 Microsoft Corporation MIT */
22
declare module "util" {
33
import { HttpPostMessage } from 'http-post-message';
4-
global {
5-
interface Window {
6-
msCrypto: Crypto;
7-
}
8-
}
94
/**
105
* Raises a custom event with event data on the specified HTML element.
116
*

dist/powerbi.js

+6-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/powerbi.min.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/util.ts

-5
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
import { HttpPostMessage } from 'http-post-message';
2-
declare global {
3-
interface Window {
4-
msCrypto: Crypto;
5-
}
6-
}
72

83
/**
94
* Raises a custom event with event data on the specified HTML element.

0 commit comments

Comments
 (0)