Skip to content

Commit d51167b

Browse files
Shahak Yosefneryaco
Shahak Yosef
authored andcommitted
Merged PR 147040: [RDL Embed] Parameter panel settings
Fix parameter panel settings. By default it is enabled and expanded. Dist and package.json will be updated after models release. Models PR: !147041 FE PR: !147039 ```typescript var config = { type: 'report', tokenType: tokenType == '0' ? models.TokenType.Aad : models.TokenType.Embed, accessToken: txtAccessToken, embedUrl: txtEmbedUrl, id: txtEmbedReportId, permissions: permissions, settings:{ commands:{ parameterPanel:{ enabled: true, expanded: false }}} }; ```
1 parent 9828a88 commit d51167b

File tree

6 files changed

+481
-55
lines changed

6 files changed

+481
-55
lines changed

dist/powerbi-client.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// powerbi-client v2.17.2
1+
// powerbi-client v2.18.0
22
// Copyright (c) Microsoft Corporation.
33
// Licensed under the MIT License.
44
declare module "util" {

dist/powerbi.js

+470-46
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/powerbi.min.js

+3-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "powerbi-client",
3-
"version": "2.17.2",
3+
"version": "2.18.0",
44
"description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",
55
"main": "dist/powerbi.js",
66
"types": "dist/powerbi-client.d.ts",
@@ -81,7 +81,7 @@
8181
},
8282
"dependencies": {
8383
"http-post-message": "^0.2",
84-
"powerbi-models": "^1.8",
84+
"powerbi-models": "^1.9",
8585
"powerbi-router": "^0.1",
8686
"window-post-message-proxy": "^0.2"
8787
},

src/config.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
/** @ignore *//** */
55
const config = {
6-
version: '2.17.2',
6+
version: '2.18.0',
77
type: 'js'
88
};
99

src/report.ts

+4
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
LayoutType,
1515
SectionVisibility,
1616
validateReportLoad,
17+
validatePaginatedReportLoad,
1718
ViewMode,
1819
IEmbedConfiguration,
1920
IEmbedConfigurationBase,
@@ -437,6 +438,9 @@ export class Report extends Embed implements IReportNode, IFilterable {
437438
* @hidden
438439
*/
439440
validate(config: IEmbedConfigurationBase): IError[] {
441+
if (isRDLEmbed(this.config.embedUrl)) {
442+
return validatePaginatedReportLoad(config);
443+
}
440444
return validateReportLoad(config);
441445
}
442446

0 commit comments

Comments
 (0)