Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policies with a lower priority affecting score #267

Open
mrapoc opened this issue Nov 14, 2023 · 3 comments
Open

Policies with a lower priority affecting score #267

mrapoc opened this issue Nov 14, 2023 · 3 comments

Comments

@mrapoc
Copy link

mrapoc commented Nov 14, 2023

I have noticed that when a policy (usually default) does not have a recommended setting, but a custom policy (for example) with a higher priority does, it still marks negatively.

It would be beneficial that if the recommended setting is applied regardless of other policies it should be marked as correct.

@cammurray
Copy link
Owner

Hey @mrapoc, this is by design due to the way that policies work.

Whilst we can determine based on the priority, we can't determine based on the scope of the policies that the policy is in use/or not in use.

Give you an example; if an organisation has two domains contoso.com, fabrikam.com. You could create a policy for contoso and a policy for fabrikam (based on the recipient scope), those policies would have different orders - and both are 'active' but for different recipient domains. The policies are applied based on going through them in priority order and assessing them against the scope - first hit wins. Effectively; the priority order is not the only factor in determining if a policy is in use or not.

So from the perspective of the report, we have to consider that any policy that is not disabled, could effectively be active for users in the organisation based on scope, and the dangers of accidental policy "enablement" due to priority orders are even higher when using groups for scoping (not domains), or if you have a large amount of recipient domains.

It's for this reason that we suggest either; disabling the policy that is not in use so that it cannot become "active" for a user if there is a scope exemption, or making sure that all policies meet the bar to reduce that risk.

@mrapoc
Copy link
Author

mrapoc commented Nov 16, 2023 via email

@cammurray
Copy link
Owner

Hey @mrapoc thanks for responding.

I would recommend still ensuring the default policy meets your minimum bar as there is no “apply to all” option today in the policy scope - this means that it is possible these policies could be hit. I would always make sure your default policy meets your minimum bar.

There is a point around ignoring default in the instances where there is a baseline policy that has no exceptions (base line policies can still have an exception list, which would cause your default policy to hit or another lower ordered policy). We can definitely look at that (ignoring default in the instance of strict/standard policies being used, where there is no exceptions on the policy).

I have a backlog item #238 that has the intent for basic scope checks (where the exception/and condition are domains). But scope checks on groups aren’t really possible at the scope of this project, because that would mean we need to expand/assess groups to determine coverage - which might be fine on an org of 100-1000 users, but ORCA is used on tenants that are 50-100k+

What’s your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants