Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Local Hub aware of Public Hub and validate TypeInstances #633

Open
mszostok opened this issue Feb 13, 2022 · 0 comments
Open

Make Local Hub aware of Public Hub and validate TypeInstances #633

mszostok opened this issue Feb 13, 2022 · 0 comments
Labels
area/hub Relates to Hub enhancement New feature or request
Milestone

Comments

@mszostok
Copy link
Member

mszostok commented Feb 13, 2022

Description

Validation for TypeInstances was implemented in Argo actions and CLI (https://github.com/capactio/capact/pull/629/files). This doesn't solve the problem when someone will submit it via GraphQL (e.g. via UI). We should move validation logic directly to Local Hub. As a result, we will have a single entry point where this will be validated no matter who/what sent the TypeInstance.

To make this work, we need to add information to Local Hub with which Public Hub it should work. As a result, we can also validate whether created TypeInstance refers to existing TypeRef.

Reason

Validate TypeInstance no matter who sends it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hub Relates to Hub enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant