Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add thymus support #46

Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat: add thymus support #46

merged 1 commit into from
Feb 4, 2025

Conversation

strieflin
Copy link
Member

No description provided.

@sbckr sbckr self-requested a review January 31, 2025 12:58
@sbckr sbckr force-pushed the add-thymus-support branch from 3979b9f to 22dd879 Compare January 31, 2025 12:59
@sbckr sbckr marked this pull request as ready for review January 31, 2025 12:59
@sbckr sbckr requested a review from a team as a code owner January 31, 2025 12:59
@sbckr sbckr force-pushed the add-thymus-support branch 2 times, most recently from f9b4cc6 to 01c1e9d Compare January 31, 2025 13:04

Verified

This commit was signed with the committer’s verified signature.
sbckr Sebastian Becker
Signed-off-by: Sebastian Becker <[email protected]>
Co-Authored: Sven Trieflinger <[email protected]>
Signed-off-by: Sebastian Becker <[email protected]>
@sbckr sbckr force-pushed the add-thymus-support branch from 01c1e9d to dbeb2c6 Compare January 31, 2025 13:15
@sbckr sbckr changed the title Initial implementation (WIP) feat: add thymus support Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 13 lines in your changes missing coverage. Please review.

Project coverage is 84.19%. Comparing base (2b92b9e) to head (dbeb2c6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...t/thymus/command/ThymusClientCliCommandRunner.java 80.43% 6 Missing and 3 partials ⚠️
...arbynestack/cli/client/thymus/ThymusClientCli.java 66.66% 2 Missing ⚠️
...rbynestack/cli/configuration/VcpConfiguration.java 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
+ Coverage     83.82%   84.19%   +0.36%     
- Complexity      400      435      +35     
============================================
  Files            69       77       +8     
  Lines          1515     1632     +117     
  Branches         81       86       +5     
============================================
+ Hits           1270     1374     +104     
- Misses          186      195       +9     
- Partials         59       63       +4     
Files with missing lines Coverage Δ
...ain/java/io/carbynestack/cli/CsCliApplication.java 76.92% <100.00%> (+0.25%) ⬆️
...command/GetPolicyThymusClientCliCommandRunner.java 100.00% <100.00%> (ø)
...mand/ListPoliciesThymusClientCliCommandRunner.java 100.00% <100.00%> (ø)
.../config/GetPolicyThymusClientCliCommandConfig.java 100.00% <100.00%> (ø)
...nfig/ListPoliciesThymusClientCliCommandConfig.java 100.00% <100.00%> (ø)
...li/client/thymus/config/ThymusClientCliConfig.java 100.00% <100.00%> (ø)
...cli/client/thymus/converter/PolicyIDConverter.java 100.00% <100.00%> (ø)
...arbynestack/cli/client/thymus/ThymusClientCli.java 66.66% <66.66%> (ø)
...rbynestack/cli/configuration/VcpConfiguration.java 91.05% <83.33%> (-0.84%) ⬇️
...t/thymus/command/ThymusClientCliCommandRunner.java 80.43% <80.43%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b92b9e...dbeb2c6. Read the comment docs.

Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbckr sbckr merged commit 05223fd into master Feb 4, 2025
6 checks passed
@sbckr sbckr deleted the add-thymus-support branch February 4, 2025 06:36
@cs-minion cs-minion mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants