-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Release #1716
Comments
That might be tricky due to the abseil dependency. I think (I could be wrong) that abseil would need to get packaged either upstream for ubuntu/debian/fedora, or packaged through the OSRF repos. Either option sounds like a ton of work. It seems that google isn't actively developing this project anymore; maybe it is worth removing the abseil dependency so that it is easier to compile and release? (I'm sure that would also be a massive amount of work though) |
Oh I see. Well I hope somebody who knows this repo well will have the time to create a release. |
We have cartographer (and abseil-cpp) on conda-forge, and we're really interested in a fresh release: https://github.com/conda-forge/cartographer-feedstock Conda packages work on Windows, Linux (glibc based distros) & ARM64, PPC64LE and OSX. I think another option is to statically link to abseil (not favored by distros, usually). I think google probably provides some cmake stuff to get this done? |
@jonbinney the abseil is finally on Debian Testing repos! https://tracker.debian.org/pkg/abseil ;-) I'll need Cartographer ROS packages for Focal, maybe I can help with this! But I'm not sure what is left to be done. |
@tmartinx we'd need to hear from one of the maintainers of cartographer - doing releases would need push access to this repo. In general a maintainer would have to be ready to put in the time to do releases (both the initial release and later bugfix releases). That can be quite a lot of work, especially since there are multiple ros distros to potentially release for (melodic/noetic/foxy) and multiple target linux distributions to debug the build on (ubuntu/fedora/etc). |
@MichaelGrupp What needs to be done here? For the cartographer repo, I can look into adding a new tag (and update files accordingly) similar to what was done for 1.0.0 for a new version 2.0.0. Is that all we need for the cartographer side of things? I am not sure what needs to be done on the ROS side to build packages. |
Towards cartographer-project#1716. Signed-off-by: Wolfgang Hess <[email protected]>
@MichaelGrupp My plan would be to merge #1819, create a "2.0.0" release with a tag on then current master. Do you agree that this is moving in the right direction? FYI @bochen87 |
Towards #1716. Signed-off-by: Wolfgang Hess <[email protected]>
@MichaelGrupp @bochen87 @clalancette I released a version tagged "2.0.0" of cartographer. I am not sure what the next steps regarding Cartographer ROS/ROS2 are: ideas? Anything to do for ROS1 or should we just tag a new version there? "1.5.0" maybe? Anything we can already do for ROS2? |
Agree with tagging We need to find a solution for abseil before creating a ROS release package though, it is not available via rosdep. Maybe there are also other small things that need to be tweaked in order to release to the ROS repos. Since we have a few issues with discussions about a Noetic release floating around and it's a bit messy, I created one for discussion about concrete ToDos that we need to tackle now: cartographer-project/cartographer_ros#1599 I suggest to continue the discussion there @wohe @bochen87 @clalancette. |
awesome, the PR to conda-forge is in (thanks to the bots): conda-forge/cartographer-feedstock#13 |
Hello,
Will there be a new release any time soon?
The latest release (1.0.0) is 267 commits behind the master.
The text was updated successfully, but these errors were encountered: