Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources git URL not supporting tags #287

Open
rolandknight opened this issue Jun 7, 2022 · 6 comments
Open

sources git URL not supporting tags #287

rolandknight opened this issue Jun 7, 2022 · 6 comments
Labels
good first issue Good for newcomers

Comments

@rolandknight
Copy link

The bin/hermit.hcl sources variable is not supporting repo tags. Example:
sources = ["https://gitlab.com/onis-oss/hermit-packages.git#onis-oss"]

Results in this error:
fatal:hermit: /home/rolandknight/git/gitlab.com/onis-oss/tlc/sandbox/bin/hermit.hcl: unsupported source "https://gitlab.com/onis-oss/hermit-packages.git#onis-oss"

@alecthomas
Copy link
Collaborator

Great point, we should definitely support that!

@rolandknight
Copy link
Author

rolandknight commented Jun 8, 2022 via email

@alecthomas
Copy link
Collaborator

alecthomas commented Jun 8, 2022

Oh nice, thank you. The code is currently living here, for downloading a package via git. I think this logic could be pulled out into a top-level git package, and reused by the package caching, and the sources.

@jvmakine jvmakine added the good first issue Good for newcomers label Sep 1, 2022
@jufemaiz
Copy link

jufemaiz commented Mar 2, 2023

Happy to jump into this and assist. We're wanting to use atlas and unfortunately their latest release is git tag only – not github release.

@alecthomas
Copy link
Collaborator

I'm not sure what atlas is, but this issue is specifically talking about using git tags for extra package manifest sources, not for packages themselves.

If this is Atlas, you'd likely download the tarballs from their site. If you're talking about using tags for auto-versioning, a better option would be to use the html auto-versioning. This is also what we do for Go.

@jufemaiz
Copy link

jufemaiz commented Mar 2, 2023

@alecthomas thanks for the clarification! Taking up the need for an index page of releases with the Atlas team (it's this atlas for clarification).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants