Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks implementation missing the during_initial_install handling #69

Closed
aspark21 opened this issue Sep 14, 2024 · 2 comments
Closed

Hooks implementation missing the during_initial_install handling #69

aspark21 opened this issue Sep 14, 2024 · 2 comments

Comments

@aspark21
Copy link

The implementation in #66 results in the issue #68 because during_initial_install isn't handled

https://moodledev.io/docs/4.4/apis/core/hooks#example-of-hook-callback-registration

@leonstr
Copy link
Contributor

leonstr commented Sep 20, 2024

Proposed fix in PR #70 .

@djarran
Copy link
Contributor

djarran commented Oct 18, 2024

This was implemented by @leonstr in pull request #70 that is now merged. Closing as complete

@djarran djarran closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants