Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shared simp only with custom tactics #279

Open
1 of 2 tasks
andrewmwells-amazon opened this issue Apr 10, 2024 · 1 comment
Open
1 of 2 tasks

Refactor shared simp only with custom tactics #279

andrewmwells-amazon opened this issue Apr 10, 2024 · 1 comment
Labels
feature-request Request for a new feature

Comments

@andrewmwells-amazon
Copy link
Contributor

Category

Lean formalization

Describe the feature you'd like to request

As pointed out here #278 (comment) there are many almost identical simp only instances we could rewrite more cleanly with a custom tactic.

Describe alternatives you've considered

N/A

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@andrewmwells-amazon andrewmwells-amazon added feature-request Request for a new feature pending-triage Hasn't been triaged yet labels Apr 10, 2024
@cdisselkoen cdisselkoen added backlog and removed pending-triage Hasn't been triaged yet labels Apr 22, 2024
@andrewmwells-amazon
Copy link
Contributor Author

From a Zulip thread:
We should import

import Lean.Elab.Tactic.Simp

register_simp_attr bv_normalize

then add

@[bv_normalize]

before the defs in question and then

simp only [bv_normalize]

will do what we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants