Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

danger rulez parser: pre-compile regular expressions #1800

Open
ghost opened this issue Mar 12, 2021 · 0 comments
Open

danger rulez parser: pre-compile regular expressions #1800

ghost opened this issue Mar 12, 2021 · 0 comments
Labels
good first issue Indicates a good issue for first-time contributors

Comments

@ghost
Copy link

ghost commented Mar 12, 2021

These regular expressions should be compiled using re.compile:

intelmq/intelmq/bots/parsers/danger_rulez/parser.py

Lines 7 to 8 in 420a8d4

REGEX_IP = "^[^ \t]+"
REGEX_TIMESTAMP = "# ([^ \t]+ [^ \t]+)"

@ghost ghost added the good first issue Indicates a good issue for first-time contributors label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Indicates a good issue for first-time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants