From 7d75bfa137be713848459bb87f2d98271cd4f10f Mon Sep 17 00:00:00 2001 From: Zach Panzarino Date: Fri, 8 Sep 2017 01:24:50 +0000 Subject: [PATCH] Update for release Remove last_update on info objects Remove dependencies on requests and dateutil --- mlbgame/info.py | 12 +----------- setup.py | 2 +- tests/test_info.py | 3 --- 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/mlbgame/info.py b/mlbgame/info.py index 8b2c1eb..33f0ab7 100644 --- a/mlbgame/info.py +++ b/mlbgame/info.py @@ -10,7 +10,6 @@ import mlbgame.object from datetime import datetime -import dateutil.parser import json import lxml.etree as etree import requests @@ -135,16 +134,13 @@ def roster(team_id): data = mlbgame.data.get_roster(team_id) parsed = json.loads(data.read().decode('utf-8')) players = parsed['roster_40']['queryResults']['row'] - last_update = dateutil.parser.parse( - parsed['roster_40']['queryResults']['created']) - return {'players': players, 'last_update': last_update, 'team_id': team_id} + return {'players': players, 'team_id': team_id} class Roster(object): """Represents an MLB Team Properties: - last_update players team_id """ @@ -154,7 +150,6 @@ def __init__(self, data): `data` should be a dictionary of values. """ - self.last_update = data['last_update'] self.team_id = data['team_id'] self.players = [] for player in data['players']: @@ -217,8 +212,6 @@ def standings(date): data = mlbgame.data.get_historical_standings(date) standings_schedule_date = 'historical_standings_schedule_date' parsed = json.loads(data.read().decode('utf-8')) - last_update = parsed[standings_schedule_date][ - 'standings_all_date_rptr']['standings_all_date'][0]['queryResults']['created'] sjson = parsed[standings_schedule_date]['standings_all_date_rptr']['standings_all_date'] for league in sjson: if league['league_id'] == '103': @@ -235,7 +228,6 @@ def standings(date): return { 'standings_schedule_date': standings_schedule_date, 'divisions': divisions, - 'last_update': dateutil.parser.parse(last_update) } @@ -245,7 +237,6 @@ class Standings(object): Properties: divisions standings_schedule_date - last_update """ def __init__(self, data): @@ -254,7 +245,6 @@ def __init__(self, data): `data` should be a dictionary of values """ self.standings_schedule_date = data['standings_schedule_date'] - self.last_update = data['last_update'] self.divisions = [Division(x['division'], x['teams']) for x in data['divisions']] diff --git a/setup.py b/setup.py index f3d404b..f88ee68 100644 --- a/setup.py +++ b/setup.py @@ -63,7 +63,7 @@ packages=['mlbgame'], package_data={'mlbgame': ['default.xml']}, data_files=[('docs', ['README.md', 'LICENSE', 'description.rst'])], - install_requires=['lxml', 'requests', 'python-dateutil'], + install_requires=['lxml'], extras_require={ 'dev': ['pytest', 'pytest-cov', 'coveralls'] } diff --git a/tests/test_info.py b/tests/test_info.py index 86ee8ba..b4b84df 100644 --- a/tests/test_info.py +++ b/tests/test_info.py @@ -221,7 +221,6 @@ def test_teams(self): def test_roster(self): roster = mlbgame.roster(121) - self.assertIsInstance(roster.last_update, datetime) self.assertIsInstance(roster.players, list) for player in roster.players: self.assertIsInstance(player.bats, str) @@ -258,7 +257,6 @@ def test_roster(self): def test_standings(self): standings = mlbgame.standings() self.assertEqual(standings.standings_schedule_date, 'standings_schedule_date') - self.assertIsInstance(standings.last_update, datetime) self.assertIsInstance(standings.divisions, list) for division in standings.divisions: self.assertIsInstance(division.name, str) @@ -314,7 +312,6 @@ def test_standings_historical(self): date = datetime(2016, 6, 1) standings = mlbgame.standings(date) self.assertEqual(standings.standings_schedule_date, 'historical_standings_schedule_date') - self.assertIsInstance(standings.last_update, datetime) self.assertIsInstance(standings.divisions, list) for division in standings.divisions: self.assertIsInstance(division.name, str)