Don't use ==

slandelle · slandelle · commit 2ded5269fd60 · 2016-11-07T17:43:30.000+01:00
diff --git a/netty-utils/src/main/java/org/asynchttpclient/netty/util/ByteBufUtils.java b/netty-utils/src/main/java/org/asynchttpclient/netty/util/ByteBufUtils.java
@@ -27,15 +27,15 @@ private ByteBufUtils() {
     }
 
     public static String byteBuf2String(Charset charset, ByteBuf buf) throws CharacterCodingException {
-        if (charset == UTF_8 || charset == US_ASCII) {
+        if (charset.equals(UTF_8) || charset.equals(US_ASCII)) {
             return Utf8ByteBufCharsetDecoder.decodeUtf8(buf);
         } else {
             return buf.toString(charset);
         }
     }
 
     public static String byteBuf2String(Charset charset, ByteBuf... bufs) throws CharacterCodingException {
-        if (charset == UTF_8 || charset == US_ASCII) {
+        if (charset.equals(UTF_8) || charset.equals(US_ASCII)) {
             return Utf8ByteBufCharsetDecoder.decodeUtf8(bufs);
         } else {
             CompositeByteBuf composite = Unpooled.compositeBuffer(bufs.length);

Original file line number	Diff line number	Diff line change
`@@ -27,15 +27,15 @@ private ByteBufUtils() {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`public static String byteBuf2String(Charset charset, ByteBuf buf) throws CharacterCodingException {`
`30`		`- if (charset == UTF_8 \|\| charset == US_ASCII) {`
	`30`	`+ if (charset.equals(UTF_8) \|\| charset.equals(US_ASCII)) {`
`31`	`31`	`return Utf8ByteBufCharsetDecoder.decodeUtf8(buf);`
`32`	`32`	`} else {`
`33`	`33`	`return buf.toString(charset);`
`34`	`34`	`}`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`public static String byteBuf2String(Charset charset, ByteBuf... bufs) throws CharacterCodingException {`
`38`		`- if (charset == UTF_8 \|\| charset == US_ASCII) {`
	`38`	`+ if (charset.equals(UTF_8) \|\| charset.equals(US_ASCII)) {`
`39`	`39`	`return Utf8ByteBufCharsetDecoder.decodeUtf8(bufs);`
`40`	`40`	`} else {`
`41`	`41`	`CompositeByteBuf composite = Unpooled.compositeBuffer(bufs.length);`