Properly clear Utf8ByteBufCharsetDecoder's charBuffer, close AsyncHttpClient#1303

slandelle · slandelle · commit b3c4ba57d33e · 2016-11-07T21:54:13.000+01:00
diff --git a/netty-utils/src/main/java/org/asynchttpclient/netty/util/Utf8ByteBufCharsetDecoder.java b/netty-utils/src/main/java/org/asynchttpclient/netty/util/Utf8ByteBufCharsetDecoder.java
@@ -74,7 +74,7 @@ private void ensureCapacity(int l) {
 
     public void reset() {
         decoder.reset();
-        charBuffer.position(0);
+        charBuffer.clear();
     }
 
     private static int charSize(byte firstByte) throws CharacterCodingException {

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ private void ensureCapacity(int l) {`
`74`	`74`
`75`	`75`	`public void reset() {`
`76`	`76`	`decoder.reset();`
`77`		`- charBuffer.position(0);`
	`77`	`+ charBuffer.clear();`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`private static int charSize(byte firstByte) throws CharacterCodingException {`