-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add search functionality #157
Comments
Based on our conversation internally, we likely want a pager bubble build on viewport that you could search. It would include an overlap between viewport bubble + status bar bubble. Glamour will remain a rendering lib, not something interactive. FeaturesWhat we’ve been envisioning for the pager bubble is basically rebuilding the glow pager but without glamour rendering so it’s more flexible. so basically:
Bonus
|
Hi @bashbunni ! any feedback or contributions would be greatly appreciated! |
@bashbunni yep, pretty much! |
FWIW, its not the whole search, just the highlighting of ranges in the contents results. I explained it better in #697, and there's a usage example in the gum PR linked there as well. |
Description
It would add lots of value to be able to search a document for keywords. Similar to how we filter lists or use
/
in vimRelated Issues
charmbracelet/glow#183
The text was updated successfully, but these errors were encountered: