New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support log/slog.LogValuer #96

Open

xuxife opened this issue Dec 5, 2023 · 0 comments

Labels

xuxife commented Dec 5, 2023

current logger didn't support log/slog.LogValuer, rather just a.Value.String()
should a.Value.Resolve to respect interface LogValuer

// Handle handles the Record. It will only be called if Enabled returns true.
//
// Implements slog.Handler.
func (l *Logger) Handle(_ context.Context, record slog.Record) error {
	fields := make([]interface{}, 0, record.NumAttrs()*2)
	record.Attrs(func(a slog.Attr) bool {
		fields = append(fields, a.Key, a.Value.String())        <- a.Value.String()
		return true
	})

The text was updated successfully, but these errors were encountered:

aymanbagabas added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment