Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database and clicking on spectra #1578

Closed
lpatiny opened this issue Jun 7, 2022 · 5 comments
Closed

Database and clicking on spectra #1578

lpatiny opened this issue Jun 7, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@lpatiny
Copy link
Member

lpatiny commented Jun 7, 2022

Hope this can be done without hacks otherwise we should reconsider this feature.

From the database panel when we click on a line the spectrum should be added and stay even we leave the row.

We could select many rows as well !!!! So we can click to select, click to unselected but we can apply this on many rows.

As vertical position we should use the default behaviour from the 'stack', see the related issue:
#1577

It would be nice to also have different colors for the spectra.

@lpatiny lpatiny added the enhancement New feature or request label Jun 7, 2022
@hamed-musallam
Copy link
Member

@lpatiny

From the database panel when we click on a line the spectrum should be added and stay even we leave the row.

Do you mean temporary or add it to the spectra and be visible in the spectra list

As vertical position we should use the default behaviour from the 'stack', see the related issue:

what is going to happen with margin-bottom in the database preferences?

@lpatiny
Copy link
Member Author

lpatiny commented Jun 7, 2022

This is temporary.

Indeed I just saw you have margin bottom (px) and color already in preferences.

I don't know what is the best way to proceed and it depends what is the simplest to develop. You may as well keep this property (margin bottom) and add a 'space' property to have the first spectrum position and then the distance between spectra.
As for the color for now they could have all the same color.

@hamed-musallam
Copy link
Member

@lpatiny

is it acceptable to you if we add the spectrum to the spectra list like when we press on the '+' button and remove it once the user clicks again on the row, and keep the current functionality for mouse over as it is currently?

@lpatiny
Copy link
Member Author

lpatiny commented Jun 16, 2022

If it is easier to implement it looks like a good approach.

@hamed-musallam
Copy link
Member

resolved by 8e8b0f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants