Skip to content

Commit 3b68902

Browse files
committed
🚿
1 parent bcbeb6b commit 3b68902

File tree

2 files changed

+5
-28
lines changed

2 files changed

+5
-28
lines changed

tests/Psr18/URLExtractorTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ public function testSendRequest():void{
3434

3535
if(defined('TEST_IS_CI') && TEST_IS_CI === true){
3636
$this->markTestSkipped('i have no idea why the headers are empty on travis');
37-
38-
return;
3937
}
4038

4139
// reminder: twitter does not delete shortened URLs of deleted tweets (this one was deleted in 2016)

tests/Psr7/UriTest.php

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -139,48 +139,33 @@ public function testWithPortCannotBeZero():void{
139139
(new Uri)->withPort(0);
140140
}
141141

142-
/* public function testParseUriPortCannotBeZero():void{
143-
144-
// @todo: this test can either be removed ot the behaviour changed in the Uri class.
145-
146-
if(\PHP_VERSION_ID < 70413){ // fixed in 7.4.13, 7.3.25
147-
$this::markTestSkipped('https://bugs.php.net/bug.php?id=80266');
148-
return;
149-
}
150-
151-
$this->expectException(InvalidArgumentException::class);
152-
$this->expectExceptionMessage('invalid URI: "//example.com:0');
153-
154-
new Uri('//example.com:0');
155-
}*/
156-
157142
public function testSchemeMustHaveCorrectType():void{
158143
$this->expectException(InvalidArgumentException::class);
159-
144+
/** @noinspection PhpParamsInspection */
160145
(new Uri)->withScheme([]);
161146
}
162147

163148
public function testHostMustHaveCorrectType():void{
164149
$this->expectException(InvalidArgumentException::class);
165-
150+
/** @noinspection PhpParamsInspection */
166151
(new Uri)->withHost([]);
167152
}
168153

169154
public function testPathMustHaveCorrectType():void{
170155
$this->expectException(InvalidArgumentException::class);
171-
156+
/** @noinspection PhpParamsInspection */
172157
(new Uri)->withPath([]);
173158
}
174159

175160
public function testQueryMustHaveCorrectType():void{
176161
$this->expectException(InvalidArgumentException::class);
177-
162+
/** @noinspection PhpParamsInspection */
178163
(new Uri)->withQuery([]);
179164
}
180165

181166
public function testFragmentMustHaveCorrectType():void{
182167
$this->expectException(InvalidArgumentException::class);
183-
168+
/** @noinspection PhpParamsInspection */
184169
(new Uri)->withFragment([]);
185170
}
186171

@@ -349,12 +334,6 @@ public function uriComponentsEncodingProvider():array{
349334

350335
/**
351336
* @dataProvider uriComponentsEncodingProvider
352-
*
353-
* @param $input
354-
* @param $path
355-
* @param $query
356-
* @param $fragment
357-
* @param $output
358337
*/
359338
public function testUriComponentsGetEncodedProperly(
360339
string $input,

0 commit comments

Comments
 (0)