From 204f8f8ea431903bedbe3038cc9dc5b76fecba0b Mon Sep 17 00:00:00 2001 From: Satoshi Tanda Date: Sun, 7 Oct 2018 10:02:35 -0700 Subject: [PATCH] fix a comment error, and typo in README --- README.md | 6 +++--- src/hvpp/hvpp/vcpu.cpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 57e792f..3335297 100644 --- a/README.md +++ b/README.md @@ -93,7 +93,7 @@ read and navigate through 5000 pages with browser's built-in PDF reader. - destroy each VCPU via IPI - for each VCPU `vmexit_handler::invoke_termination()` is called within `vcpu_t::destroy()` method, which should be responsible for switching into VMX mode and then call `vcpu_t::terminate()` - this is by default handled via `VMCALL` instruction - - `vcpu_t::terminate()` leaves VMX mode with `VMXOFF` instruction (which is available only in VMX mode), + - `vcpu_t::terminate()` leaves VMX mode with `VMXOFF` instruction (which is available only in VMX mode), ### Compilation @@ -192,7 +192,7 @@ After that, **hvppctrl**: - because the function is still hooked, the hook function will be called and `HookCallCount` will be incremented again - prints value of `HookCallCount` and it's expected value - it should be 3 -- unhooks `ntdll!ZwClose` fuction +- unhooks `ntdll!ZwClose` function - disassembles first 16 bytes of this function and prints them - printed instructions should now indicate that the function is **NOT** hooked - it should show the same content as when this function wasn't hooked @@ -221,7 +221,7 @@ When you decide you want to turn off the **hvpp**, just execute: ### Remarks -- **hvpp** is designed to virtualize already running OS - i.e. it's not cappable of running multiple guests like VMWare +- **hvpp** is designed to virtualize already running OS - i.e. it's not capable of running multiple guests like VMWare or VirtualBox. It also lacks support for any nested VMX operations. - **hvpp** is designed to run only on 64bit Intel processors, which support VT-x and EPT. This makes the code more simple and less bloated. diff --git a/src/hvpp/hvpp/vcpu.cpp b/src/hvpp/hvpp/vcpu.cpp index 615e74e..04c5bf0 100644 --- a/src/hvpp/hvpp/vcpu.cpp +++ b/src/hvpp/hvpp/vcpu.cpp @@ -426,7 +426,7 @@ void vcpu_t::setup_guest() noexcept // Set zero-ed out MSR bitmap. Note that we would still get VM-exit for each // MSR access, if the MSR ID is out of following ranges: // 0x00000000 - 0x00001fff and - // 0x80000000 - 0x80001fff + // 0xc0000000 - 0xc0001fff // msr_bitmap(vmx::msr_bitmap_t{ 0 });