-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New messages don't scroll to bottom when tab is out of focus #1500
Comments
This seems to also happen if you are tabbed out with a separate window (like a PWA in Chromium). |
It also happens when I have the window/chat focussed. |
This comment was marked as duplicate.
This comment was marked as duplicate.
It would be nice if a maintainer could chime in on whether the behavior described in this issue is intended and how the expectation mismatch experienced by some users should be addressed. I'd love to patch this, but I don't want to waste my time writing a fix that will be rejected. |
the current behavior is intended as previously people had issues that "chat marked as read in background" #1116 browser doesn't have any api which can tell if application is being viewed when not in focused(i.e on second monitor) we can't really fix it without breaking it otherwise. |
I wonder how other similar applications deal with this, as I've never really noticed issues like this anywhere else. My preferred behaviour would be that cinny scrolls down automatically, but only marks the chat as read once the window is actually focused / interacted with – which from all I gather is the behaviour of most other comparable applications. Assuming that that's technically possible, but not necessarily desired by the maintainers, would there be a chance to make this a configurable option? |
The reason we can do it like other applications is because we have read-receipts, which tells other person that user has read the messages in that case we can not be sure about if user has read the message or not when application is in background. |
would a patch that adds an option to disable this behavior for users who don't want it be acceptable? |
Adding a option won't be a good fix as there may be a cleaver fix which we can think through. |
I think that just because you can see the messages on screen while the app is not in focus doesn't mean that you should send a read receipt. I think it should scroll to the bottom regardless of focus, but only mark it as read if the window has focus. (Although we should consider the case where after regaining focus you might not want to mark all those messages as read right away.) |
My suggestion:
(this is basically what Discord does) You could also instead consider stopping the auto-scrolling after some amount of new unread messages (preferably after they reach the top of the screen), and then mark them read once the user scrolls to the bottom manually |
This comment has been minimized.
This comment has been minimized.
#2214 to fix it. Feel free to test if it is a desirable behavior. |
Describe the bug
Normally when a message is sent in a room, the scrollbar stays locked to the bottom. However, when a message is sent and Cinny isn't the current tab in the browser, the scrollbar stays fixed to the last read message, so you have to scroll down to see new messages every time you switch back to the Cinny tab, which I find annoying.
Reproduction
Expected behavior
The scrollbar should stay at the bottom.
Platform and versions
Additional context
No response
The text was updated successfully, but these errors were encountered: