Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add m.mentions to user when replying to a message #1544

Closed
xtexx opened this issue Nov 11, 2023 · 0 comments · Fixed by #2138
Closed

Add m.mentions to user when replying to a message #1544

xtexx opened this issue Nov 11, 2023 · 0 comments · Fixed by #2138

Comments

@xtexx
Copy link

xtexx commented Nov 11, 2023 •
edited
Loading

Describe the problem

matrix spec 1.8 11.3.2

In order to notify users of the reply, it may be desirable to include the sender of the replied to event and any users mentioned in that event. See user and room mentions for additional information.

Describe the solution you'd like

Mention the replied user.

Alternatives considered

however, is there any differences between a message with mention and a without?

update: I found there is some visual differences on element. but almost no visual difference on cinny.

Additional context

No response
xtexx added a commit to xtexx/akari-bot that referenced this issue Nov 11, 2023
@xtexx
fix: add m.mentions to all matrix rich replies
b0b8f6f 
Some clients still show red-circle notifications when rich-reply messages are received but sometimes the events may be skipped.
Matrix spec says it is "desirable" to add user mentions to rich-reply messages.
Element, SchindiChat uses this but Cinny doesn't.
<cinnyapp/cinny#1544>

Signed-off-by: xtex <[email protected]>
@xtexx xtexx mentioned this issue Nov 11, 2023
Merged
Dianliang233 pushed a commit to Teahouse-Studios/akari-bot that referenced this issue Nov 11, 2023
@xtexx
fix: add m.mentions to all matrix rich replies (#1016)
fb8975c 
Some clients still show red-circle notifications when rich-reply messages are received but sometimes the events may be skipped.
Matrix spec says it is "desirable" to add user mentions to rich-reply messages.
Element, SchindiChat uses this but Cinny doesn't.
<cinnyapp/cinny#1544>

Signed-off-by: xtex <[email protected]>
@tezlm tezlm mentioned this issue Sep 13, 2024
Closed
@nexy7574 nexy7574 mentioned this issue Jan 5, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove fallback replies & implement intentional mentions nexy7574/cinny
1 participant
@xtexx