Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible typo #25

Open
florius0 opened this issue Aug 26, 2021 · 2 comments
Open

Possible typo #25

florius0 opened this issue Aug 26, 2021 · 2 comments
Labels
need verification The described bug needs verification

Comments

@florius0
Copy link

It seems that I found typo in lib/clickhouse_ecto/storage.ex.

There is a call HTTPoison.start/0 on 70 line. HTTPoison is not listed in deps. Is that call necessary?
@sirikid
Copy link
Member

sirikid commented Sep 1, 2021

I have no idea what is going on there

clickhouse_ecto/lib/clickhouse_ecto/storage.ex

Line 70 in bc963d3

HTTPoison.start()

@sirikid sirikid added the need verification The described bug needs verification label Sep 1, 2021
@sshkarupa
Copy link

@sirikid As far as I see HTTPoison was a dependency for https://github.com/clickhouse-elixir/clickhousex and it was replaced by https://github.com/elixir-mint/mint.

HTTPoison.start() should be removed. There's no reason to keep it.

sirikid added a commit that referenced this issue Jan 16, 2022
@sirikid
Bump dependencies
3400e34 
Bump clickhousex to 0.5.0, remove HTTPoison. Fix #25.
@sirikid sirikid mentioned this issue Jan 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need verification The described bug needs verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump dependencies clickhouse-elixir/clickhouse_ecto
3 participants
@sirikid @sshkarupa @florius0