Skip to content

Commit 82d2bac

Browse files
committed
simple-map-entry missing ISequential marker protocol
- add test assertions for the cases considered along the way to the problem - cljs.core-test now passing under :lite-mode true
1 parent 838046a commit 82d2bac

File tree

2 files changed

+17
-9
lines changed

2 files changed

+17
-9
lines changed

src/main/cljs/cljs/core.cljs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10382,6 +10382,7 @@ reduces them without incurring seq initialization"
1038210382
(-count [coll] 2)
1038310383
IHash
1038410384
(-hash [coll] (hash-ordered-coll [k v]))
10385+
ISequential
1038510386
IEquiv
1038610387
(-equiv [coll other] (equiv-sequential coll other))
1038710388
IVector

src/test/cljs/cljs/lite_collections_test.cljs

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,29 @@
1919
(is (== 1 (:foo a)))))
2020

2121
(deftest test-simple-map-entry-eq-hash
22+
(is (= (simple-map-entry 1 2) (simple-map-entry 1 2)))
2223
(is (= (simple-map-entry 1 2)
23-
(MapEntry. 1 2 nil)))
24+
(MapEntry. 1 2 nil)))
2425
(is (== (hash (simple-map-entry 1 2))
2526
(hash (MapEntry. 1 2 nil)))))
2627

2728
(deftest test-simple-set-with-set
2829
(is (= (simple-set []) (set [])))
29-
(is (= (set []) (simple-set []))))
30+
(is (= (set []) (simple-set [])))
31+
(is (= (simple-set [(simple-map-entry 1 2)])
32+
(set [(MapEntry. 1 2 nil)]))))
3033

31-
(comment
34+
(deftest test-hash-map-simple-map-entry
35+
(let [m (assoc (. HashMap -EMPTY) (simple-map-entry 1 2) true)]
36+
(is (contains? m (simple-map-entry 1 2)))))
37+
38+
(deftest test-simple-set-simple-map-entry
39+
(let [a (simple-set [(simple-map-entry 1 2)])]
40+
(is (contains? a (simple-map-entry 1 2)))))
3241

33-
(require '[cljs.lite-collections-test] :reload)
34-
(cljs.test/run-tests)
42+
(comment
3543

36-
;; failing
37-
(= (simple-set [(simple-map-entry 1 2)])
38-
(set [(MapEntry. 1 2 nil)]))
44+
(require '[cljs.lite-collections-test])
45+
(cljs.test/run-tests)
3946

40-
)
47+
)

0 commit comments

Comments
 (0)