Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting error responses between S3 and CloudFront #25

Open
renandincer opened this issue Jul 8, 2016 · 2 comments
Open

Conflicting error responses between S3 and CloudFront #25

renandincer opened this issue Jul 8, 2016 · 2 comments
Assignees
@renandincer
Labels
bug

Comments

@renandincer
Copy link
Member

renandincer commented Jul 8, 2016 •
edited
Loading

Upon creation, S3 error pages are set to return /error.html
https://github.com/EagerIO/Stout/blob/master/src/admin.go#L27

meanwhile CloudFront errors return /index.html to support single page web apps.
https://github.com/EagerIO/Stout/blob/master/src/admin.go#L106

this might be confusing/contradicting
@renandincer renandincer self-assigned this Jul 8, 2016
@renandincer renandincer changed the title Conflicting error responses between s3 and cloudfront Conflicting error responses between S3 and CloudFront Jul 8, 2016
@renandincer
Copy link
Member Author

@zackbloom

@zackbloom
Copy link
Contributor

So the general idea is to just kill the version which is assigned in S3? That makes sense to me.

@renandincer renandincer added the bug label Jul 8, 2016
renandincer pushed a commit that referenced this issue Jul 11, 2016
Change S3 error page to index.html, closes #25
be68a0f
CyrusRoshan pushed a commit that referenced this issue Feb 19, 2019
Change S3 error page to index.html, closes #25
0976067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renandincer renandincer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zackbloom @renandincer