Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: switch to node 18 #525

Open
dario-piotrowicz opened this issue Nov 3, 2023 · 1 comment
Open

Chore: switch to node 18 #525

dario-piotrowicz opened this issue Nov 3, 2023 · 1 comment
Milestone

Comments

@dario-piotrowicz
Copy link
Member

dario-piotrowicz commented Nov 3, 2023

We are currently using node 16 for developing the package, 16 has been deprecated in September, so we should switch to just using 18 moving forward.

This involves:

  • developing the package using 18 and making sure that everything still works
  • updating our dependencies and everything that might be related to 16
    (in particular, the node-fetch dependencies we have should be removed since in 18 fetch is built in into node)
  • updating our readmes and the cloudflare docs asking users to use 18+

Note

Since this might effect existing users/applications it needs to be done in the next major release

@dario-piotrowicz dario-piotrowicz added bug Something isn't working and removed bug Something isn't working labels Nov 3, 2023
@dario-piotrowicz dario-piotrowicz added this to the V2 milestone Nov 3, 2023
@dario-piotrowicz
Copy link
Member Author

This is blocked by: #623 (and #648) since node-fetch is being used in the setupDevBindings utility, so we first need to update such utility (which can also remove the node-fetch dependency)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant