Skip to content

Commit 82e7d3d

Browse files
committed
Install the "posixrules" timezone link in MSVC builds.
Somehow, we'd missed ever doing this. The consequences aren't too severe: basically, the timezone library would fall back on its hardwired notion of the DST transition dates to use for a POSIX-style zone name, rather than obeying US/Eastern which is the intended behavior. The net effect would only be to obey current US DST law further back than it ought to apply; so it's not real surprising that nobody noticed. David Rowley, per report from Amit Kapila Discussion: https://postgr.es/m/CAA4eK1LC7CaNhRAQ__C3ht1JVrPzaAXXhEJRnR5L6bfYHiLmWw@mail.gmail.com
1 parent 9061680 commit 82e7d3d

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/tools/msvc/Install.pm

+8-3
Original file line numberDiff line numberDiff line change
@@ -308,15 +308,20 @@ sub GenerateTimezoneFiles
308308
my $conf = shift;
309309
my $mf = read_file("src/timezone/Makefile");
310310
$mf =~ s{\\\s*[\r\n]+}{}mg;
311+
311312
$mf =~ /^TZDATA\s*:?=\s*(.*)$/m
312313
|| die "Could not find TZDATA line in timezone makefile\n";
313314
my @tzfiles = split /\s+/, $1;
314315

316+
$mf =~ /^POSIXRULES\s*:?=\s*(.*)$/m
317+
|| die "Could not find POSIXRULES line in timezone makefile\n";
318+
my $posixrules = $1;
319+
$posixrules =~ s/\s+//g;
320+
315321
print "Generating timezone files...";
316322

317-
my @args = ("$conf/zic/zic",
318-
'-d',
319-
"$target/share/timezone");
323+
my @args = ("$conf/zic/zic", '-d', "$target/share/timezone",
324+
'-p', "$posixrules");
320325
foreach (@tzfiles)
321326
{
322327
my $tzfile = $_;

0 commit comments

Comments
 (0)