Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check pglast behavior. #8

Closed
lmwnshn opened this issue Feb 29, 2024 · 0 comments · Fixed by #10
Closed

Check pglast behavior. #8

lmwnshn opened this issue Feb 29, 2024 · 0 comments · Fixed by #10

Comments

@lmwnshn
Copy link
Collaborator

lmwnshn commented Feb 29, 2024

I upgraded pglast from v3 to v6. They removed their Node wrapper in v4. We should check whether the semantics remain the same, especially around previous usages of traverse.

Commit: 68e10e3
@lmwnshn lmwnshn mentioned this issue Mar 4, 2024
Merged
lmwnshn pushed a commit that referenced this issue Mar 4, 2024
@wangpatrick57
Fix extract_aliases() to ignore view names in CREATE VIEW. (#10)
66cb2d4 
This PR modifies extract_aliases() to ignore the names of views that
only appear in a CREATE VIEW statement.

These semantics were part of the old extract_aliases() function back
when we were using pglast 3.8.
When we migrated to pglast 6.2, we fixed all errors from the version
change except for the one in this PR.
Thus, this PR completes the migration.
Fix #8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix extract_aliases() to ignore view names in CREATE VIEW. wangpatrick57/dbgym_notfork
1 participant
@lmwnshn