Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storybook] PR Preview #57

Open
laurenbarker opened this issue May 21, 2020 · 0 comments
Open

[storybook] PR Preview #57

laurenbarker opened this issue May 21, 2020 · 0 comments
Assignees
@laurenbarker
Labels
📖 storybook Anything related to component catalog improvements

Comments

@laurenbarker
Copy link
Collaborator

laurenbarker commented May 21, 2020 •
edited
Loading

What

Deploy a preview for each storybook PR.

Why

So designers (and other developers) can easily review changes in a PR without checking out the branch and running it locally.

Dev notes

Look into using Netlify. If promising, get approval from security, install GitHub app, create POC with free tier first.
https://www.netlify.com/blog/2016/07/20/introducing-deploy-previews-in-netlify/
@laurenbarker laurenbarker self-assigned this May 21, 2020
@nathanstilwell nathanstilwell added the 📖 storybook Anything related to component catalog improvements label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurenbarker laurenbarker

Labels
📖 storybook Anything related to component catalog improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nathanstilwell @laurenbarker