Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving get's extremely slow #14

Open
elkowar opened this issue Apr 30, 2021 · 10 comments
Open

Saving get's extremely slow #14

elkowar opened this issue Apr 30, 2021 · 10 comments
Assignees

Comments

@elkowar
Copy link

elkowar commented Apr 30, 2021

This is really weird, but..... After setting this up, saving in my rust code started to take around 1-3 seconds of fully locked up editor. uninstalling biscuits again made everything snappy again....

@cmgriffing
Copy link
Contributor

Thanks for the report. I have a couple questions if that is ok.

@cmgriffing cmgriffing self-assigned this Apr 30, 2021
@elkowar
Copy link
Author

elkowar commented May 1, 2021

  • it's a 322 line rust file
  • idk what you mean by that 🤔
  • i think slightly, hard to tell.

@cmgriffing
Copy link
Contributor

cmgriffing commented May 1, 2021

Ok thanks.

Default mode is just when we let it redraw on every change. Non-default would be the custom events.

Could you list the other plugins you have too? I'm thinking it could also be a conflict with another plugin. (like you pointed out for gitsigns. I dont see it here, but it was in the email.)

@elkowar
Copy link
Author

elkowar commented May 1, 2021

Yea the gitsigns thing I then quickly figured out to be unrelated. All of my plugins are here: https://github.com/elkowar/dots-of-war/blob/master/files/.config/nvim/plugins.lua - it's a lot ^^'

@cmgriffing
Copy link
Contributor

Sorry for the delay in responding.
I have just now gotten around to trying to reproduce and I can't seem to do so.

I am using a 236 line Rust file, and a save seems snappy to me. No UI freeze at all.

I have to think its a conflict with another plugin. Any ideas that can help me narrow it down from your list?

@elkowar
Copy link
Author

elkowar commented May 21, 2021

@cmgriffing seems to be a conflict with https://github.com/rust-lang/rust.vim - could have tried that directly, sorry. As soon as I remove that plugin, saving works normally...

@cmgriffing
Copy link
Contributor

cmgriffing commented May 21, 2021

Awesome. Thanks for clarifying that. I can test more with it to see how I can make my plugin work better with the official rust plugin.

I will update the thread after I have tried.

@cmgriffing
Copy link
Contributor

Well, I installed the Rust plugin and still cant seem to reproduce the issue.

What version of Lua are you using? I am on LuaJIT 2.1.0.

I would be stoked to hop into a screenshare to try and troubleshoot why I can't reproduce it.

Feel free to fiddle with the code locally too, just to see if there is an easy fix that we could bring in regardless of whether I can reproduce the issue.

@elkowar
Copy link
Author

elkowar commented May 23, 2021

currently on luaJit 2.1.0. I might do some toying around with the code 👍🏻
Would be happy to try and figure this out together. When would you wanna hop into screenshare?

@cmgriffing
Copy link
Contributor

I left this hanging way too long, but could we address it some Sunday?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants