PMD Version 5.8.1 (#10)

* PMD Version 5.8.1

* Use `make upgrade` to setup a newer version

Author: filipesperandio

CONTRIBUTING.md

@@ -0,0 +1,9 @@
+# Contributing
+
+## Testing
+`make test` will build the docker image and run the tests
+
+## Upgrading PMD Version
+1. `make upgrade` => will adjust `bin/install-pmd.sh` with the URL to the latest version
+1. `make test`
+1. If all looks good, commit the change and open a PR :)

Makefile

@@ -7,3 +7,9 @@ image:
 
 test: image
 	docker run --rm -v $(PWD):/code $(IMAGE_NAME) /code/test.groovy
+
+upgrade:
+	docker run --rm \
+		--workdir /usr/src/app \
+		--volume $(PWD):/usr/src/app \
+		$(IMAGE_NAME) ./bin/upgrade.sh

bin/install-pmd.sh

@@ -3,14 +3,12 @@ set -euo pipefail
 
 LIB_DIR=/usr/src/app/lib
 
-download_latest_pmd() {
-  curl -s https://api.github.com/repos/pmd/pmd/releases/latest | \
-    jq -c '.assets[] | select(.name | contains("bin")) | .browser_download_url' | \
-    xargs wget -O pmd.zip
+download_pmd() {
+  URL="https://github.com/pmd/pmd/releases/download/pmd_releases/5.8.1/pmd-bin-5.8.1.zip"
+  wget -O pmd.zip $URL
 }
 
 install_pmd() {
-  download_latest_pmd
   unzip pmd.zip
   mv ${LIB_DIR}/pmd-bin*/* ${LIB_DIR}/pmd
 }
@@ -23,5 +21,6 @@ cleanup() {
 mkdir -p ${LIB_DIR}/pmd
 cd ${LIB_DIR}
 
+download_pmd
 install_pmd
 cleanup

bin/upgrade.sh

@@ -0,0 +1,7 @@
+#!/bin/sh
+
+URL=$(curl -s https://api.github.com/repos/pmd/pmd/releases/latest | jq -c '.assets[] | select(.name | contains("bin")) | .browser_download_url')
+ESCAPED_URL=$(echo $URL | sed 's/\&/\\&/g')
+sed -i -E "s#URL=.*#URL=${ESCAPED_URL}#" bin/install-pmd.sh
+
+echo $ESCAPED_URL