Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Commit 0ebf043

Browse files
eutopiandblandin
andauthored
Don't show total coverage delta if unavailable (#144)
* Don't show total coverage delta if unavailable * Don't show total coverage delta if insignificant change Co-authored-by: Devon Blandin <[email protected]>
1 parent e25c7c5 commit 0ebf043

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

lib/cc/presenters/pull_requests_presenter.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,11 @@ def skipped_message
3636
def coverage_message
3737
message = "#{formatted_percent(@covered_percent)}%"
3838

39-
if @covered_percent_delta > 0
39+
return message if @covered_percent_delta.nil?
40+
41+
if @covered_percent_delta.round(2) > 0
4042
message += " (+#{formatted_percent(@covered_percent_delta)}%)"
41-
elsif @covered_percent_delta < 0
43+
elsif @covered_percent_delta.round(2) < 0
4244
message += " (#{formatted_percent(@covered_percent_delta)}%)"
4345
end
4446

spec/cc/presenters/pull_requests_presenter_spec.rb

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,20 @@
3030
expect("85%").to eq(build_presenter({}, "covered_percent" => 85, "covered_percent_delta" => 0).coverage_message)
3131
end
3232

33+
it "message coverage without delta" do
34+
expect("85%").to eq(build_presenter({}, "covered_percent" => 85, "covered_percent_delta" => nil).coverage_message)
35+
end
36+
37+
it "message coverage the same when rounded" do
38+
expect("85%").to eq(build_presenter({}, "covered_percent" => 85, "covered_percent_delta" => 0.0005).coverage_message)
39+
end
40+
3341
it "message coverage up" do
3442
expect("85.5% (+2.46%)").to eq(build_presenter({}, "covered_percent" => 85.5, "covered_percent_delta" => 2.4567).coverage_message)
3543
end
3644

3745
it "message coverage down" do
38-
expect("85.35% (-3%)").to eq( build_presenter({}, "covered_percent" => 85.348, "covered_percent_delta" => -3.0).coverage_message)
46+
expect("85.35% (-3%)").to eq(build_presenter({}, "covered_percent" => 85.348, "covered_percent_delta" => -3.0).coverage_message)
3947
end
4048

4149
it "message approved" do

0 commit comments

Comments
 (0)