Fixed type errors on pages

Author: clintonwoo

src/data/models/comment.ts

@@ -6,25 +6,27 @@ import * as HNDB from '../hn-data-api';
 const logger = debug('app:Comment');
 
 export class Comment {
-  public readonly id;
-  public readonly creationTime;
-  public readonly comments;
-  public readonly parent;
-  public readonly submitterId;
-  public readonly text;
+  public readonly id: number;
+  public readonly creationTime: number;
+  public readonly comments: number[];
+  public readonly parent: number;
+  public readonly submitterId: string;
+  public readonly upvotes: string[];
+  public readonly text: string;
 
-  constructor(props) {
-    if (!props.id) throw new Error(`Error instantiating Comment, id invalid: ${props.id}`);
-    if (!props.parent) throw new Error(`Error instantiating Comment, parent invalid: ${props.parent}`);
-    if (!props.submitterId) throw new Error(`Error instantiating Comment, submitterId invalid: ${props.submitterId}`);
-    if (!props.text) throw new Error(`Error instantiating Comment, text invalid: ${props.text}`);
+  constructor(fields) {
+    if (!fields.id) throw new Error(`Error instantiating Comment, id invalid: ${fields.id}`);
+    if (!fields.parent) throw new Error(`Error instantiating Comment, parent invalid: ${fields.parent}`);
+    if (!fields.submitterId) throw new Error(`Error instantiating Comment, submitterId invalid: ${fields.submitterId}`);
+    if (!fields.text) throw new Error(`Error instantiating Comment, text invalid: ${fields.text}`);
 
-    this.id = props.id;
-    this.creationTime = props.creationTime || +new Date();
-    this.comments = props.comments || [];
-    this.parent = props.parent;
-    this.submitterId = props.submitterId;
-    this.text = props.text;
+    this.id = fields.id;
+    this.creationTime = fields.creationTime || +new Date();
+    this.comments = fields.comments || [];
+    this.parent = fields.parent;
+    this.submitterId = fields.submitterId;
+    this.text = fields.text;
+    this.upvotes = fields.upvotes || [];
   }
   static getComment = id =>
     cache.getComment(id) || HNDB.fetchComment(id).catch(reason => logger(`Rejected comment: ${reason}`));

src/data/models/news-item.ts

@@ -10,45 +10,56 @@ const logger = debug('app:NewsItem');
 let newPostIdCounter = 100;
 
 export class NewsItem {
+  /** ID of submitter */
   public readonly id: number;
+  /** Count of comments on the post */
   public readonly commentCount: number;
+  /** List of comments */
   public readonly comments;
-  public readonly creationTime;
-  public readonly hides;
-  public readonly submitterId;
-  public readonly text: string;
+  /** Post creation time, number of ms since 1970 */
+  public readonly creationTime: number;
+  /** IDs of users who hid the post */
+  public readonly hides: string[];
+  public readonly hiddenCount: number;
+  /** ID of user who submitted */
+  public readonly submitterId: string;
+  /** Body text */
+  public readonly text: string | null;
+  /** Post title */
   public readonly title: string;
-  public upvoteCount;
+  /** Number of upvotes */
+  public upvoteCount: number;
   public readonly upvotes;
   public readonly url;
 
   public readonly hidden?: boolean; // TODO: exists?
 
-  constructor(props) {
-    if (!props.id) {
-      throw new Error(`Error instantiating News Item, id is required: ${props.id}`);
+  constructor(fields) {
+    if (!fields.id) {
+      throw new Error(`Error instantiating News Item, id is required: ${fields.id}`);
     }
-    if (!props.submitterId) {
-      throw new Error(`Error instantiating News Item, submitterId is required: ${props.id}`);
+    if (!fields.submitterId) {
+      throw new Error(`Error instantiating News Item, submitterId is required: ${fields.id}`);
     }
-    if (!props.title) {
-      throw new Error(`Error instantiating News Item, title is required: ${props.id}`);
+    if (!fields.title) {
+      throw new Error(`Error instantiating News Item, title is required: ${fields.id}`);
     }
-    if (props.url && !isValidUrl(props.url)) {
-      throw new Error(`Error instantiating News Item ${props.id}, invalid URL: ${props.url}`);
+    if (fields.url && !isValidUrl(fields.url)) {
+      throw new Error(`Error instantiating News Item ${fields.id}, invalid URL: ${fields.url}`);
     }
 
-    this.id = props.id || (newPostIdCounter += 1);
-    this.commentCount = props.commentCount || 0;
-    this.comments = props.comments || [];
-    this.creationTime = props.creationTime || +new Date();
-    this.hides = props.hides || [];
-    this.submitterId = props.submitterId;
-    this.text = props.text || null;
-    this.title = props.title;
-    this.upvoteCount = props.upvoteCount || 1;
-    this.upvotes = props.upvotes || [props.submitterId];
-    this.url = props.url;
+    this.id = fields.id || (newPostIdCounter += 1);
+    this.commentCount = fields.commentCount || 0;
+    this.comments = fields.comments || [];
+    this.creationTime = fields.creationTime || +new Date();
+    this.hides = fields.hides || [];
+    this.hiddenCount = this.hides.length;
+    this.submitterId = fields.submitterId;
+    this.text = fields.text || null;
+    this.title = fields.title;
+    this.upvoteCount = fields.upvoteCount || 1;
+    this.upvotes = fields.upvotes || [fields.submitterId];
+    this.url = fields.url;
   }
 
   static getNewsItem = id => cache.getNewsItem(id) || DB.getNewsItem(id) || HNDB.fetchNewsItem(id);