Skip to content

Commit be3a169

Browse files
committed
Fix TestSignals to remove a possible race
1 parent 3882036 commit be3a169

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

session_test.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,9 @@ func TestSignals(t *testing.T) {
291291

292292
session, _, cleanup := newTestSession(t, &Server{
293293
Handler: func(s Session) {
294-
signals := make(chan Signal)
294+
// We need to use a buffered channel here, otherwise it's possible for the
295+
// second call to Signal to get discarded.
296+
signals := make(chan Signal, 2)
295297
s.Signals(signals)
296298
if sig := <-signals; sig != SIGINT {
297299
t.Fatalf("expected signal %v but got %v", SIGINT, sig)

0 commit comments

Comments
 (0)