Skip to content

Commit d88ca29

Browse files
committed
Merging r328755:
------------------------------------------------------------------------ r328755 | gbiv | 2018-03-28 20:12:03 -0700 (Wed, 28 Mar 2018) | 10 lines [MemorySSA] Turn an assert into a condition Eli pointed out that variadic functions are totally a thing, so this assert is incorrect. No test-case is provided, since the only way this assert fires is if a specific DenseMap falls back to doing `isEqual` checks, and that seems fairly brittle (and requires a pyramid of growing `call void (i8, ...) @VarArgs(i8 0)`). ------------------------------------------------------------------------ git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_60@329670 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent 2b9ba6c commit d88ca29

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/Analysis/MemorySSA.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,8 @@ class MemoryLocOrCall {
159159
if (CS.getCalledValue() != Other.CS.getCalledValue())
160160
return false;
161161

162-
assert(CS.arg_size() == Other.CS.arg_size());
163-
return std::equal(CS.arg_begin(), CS.arg_end(), Other.CS.arg_begin());
162+
return CS.arg_size() == Other.CS.arg_size() &&
163+
std::equal(CS.arg_begin(), CS.arg_end(), Other.CS.arg_begin());
164164
}
165165

166166
private:

0 commit comments

Comments
 (0)