Skip to content

Commit 6a167b6

Browse files
committed
Fix asan failure
1 parent e02cbeb commit 6a167b6

File tree

5 files changed

+12
-14
lines changed

5 files changed

+12
-14
lines changed

src/core/ext/resolver/dns/c_ares/dns_resolver_ares.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ static void dns_ares_destroy(grpc_exec_ctx *exec_ctx, grpc_resolver *gr) {
291291
if (r->resolved_result != NULL) {
292292
grpc_channel_args_destroy(exec_ctx, r->resolved_result);
293293
}
294+
grpc_pollset_set_destroy(r->interested_parties);
294295
gpr_free(r->name_to_resolve);
295296
gpr_free(r->default_port);
296297
grpc_channel_args_destroy(exec_ctx, r->channel_args);

src/core/ext/resolver/dns/c_ares/grpc_ares_ev_driver_fallback.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@
3232
*/
3333

3434
#include <grpc/support/port_platform.h>
35-
#ifdef GRPC_NATIVE_ADDRESS_RESOLVE
35+
#include "src/core/lib/iomgr/port.h"
36+
#if !(GRPC_ARES == 1 && defined(GRPC_POSIX_SOCKET))
3637

3738
#include "src/core/ext/resolver/dns/c_ares/grpc_ares_ev_driver.h"
3839

@@ -43,7 +44,7 @@ struct grpc_ares_ev_driver {
4344
void grpc_ares_ev_driver_start(grpc_exec_ctx *exec_ctx,
4445
grpc_ares_ev_driver *ev_driver) {}
4546

46-
void *grpc_ares_ev_driver_get_channel(grpc_ares_ev_driver *ev_driver) {
47+
ares_channel *grpc_ares_ev_driver_get_channel(grpc_ares_ev_driver *ev_driver) {
4748
return NULL;
4849
}
4950

@@ -52,7 +53,6 @@ grpc_error *grpc_ares_ev_driver_create(grpc_ares_ev_driver **ev_driver,
5253
return GRPC_ERROR_NONE;
5354
}
5455

55-
void grpc_ares_ev_driver_destroy(grpc_exec_ctx *exec_ctx,
56-
grpc_ares_ev_driver *ev_driver) {}
56+
void grpc_ares_ev_driver_destroy(grpc_ares_ev_driver *ev_driver) {}
5757

58-
#endif /* GRPC_NATIVE_ADDRESS_RESOLVE */
58+
#endif /* !(GRPC_ARES == 1 && defined(GRPC_POSIX_SOCKET)) */

src/core/ext/resolver/dns/c_ares/grpc_ares_ev_driver_posix.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@
4545
#include "src/core/lib/iomgr/ev_posix.h"
4646
#include "src/core/lib/iomgr/iomgr_internal.h"
4747
#include "src/core/lib/iomgr/sockaddr_utils.h"
48-
#include "src/core/lib/iomgr/unix_sockets_posix.h"
49-
#include "src/core/lib/support/block_annotate.h"
5048
#include "src/core/lib/support/string.h"
5149

5250
typedef struct fd_node {

src/core/ext/resolver/dns/c_ares/grpc_ares_wrapper.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,12 @@
4646
#include <grpc/support/host_port.h>
4747
#include <grpc/support/log.h>
4848
#include <grpc/support/string_util.h>
49-
#include <grpc/support/thd.h>
5049
#include <grpc/support/time.h>
5150
#include <grpc/support/useful.h>
5251
#include "src/core/ext/resolver/dns/c_ares/grpc_ares_ev_driver.h"
5352
#include "src/core/lib/iomgr/executor.h"
5453
#include "src/core/lib/iomgr/iomgr_internal.h"
5554
#include "src/core/lib/iomgr/sockaddr_utils.h"
56-
#include "src/core/lib/iomgr/unix_sockets_posix.h"
57-
#include "src/core/lib/support/block_annotate.h"
5855
#include "src/core/lib/support/string.h"
5956

6057
static gpr_once g_basic_init = GPR_ONCE_INIT;

src/core/ext/resolver/dns/c_ares/grpc_ares_wrapper_fallback.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,21 +34,23 @@
3434
/* TODO(zyc): remove this fallback after we can build c-ares on windows */
3535

3636
#include <grpc/support/port_platform.h>
37-
#ifdef GRPC_NATIVE_ADDRESS_RESOLVE
37+
#if !(GRPC_ARES == 1)
3838

39+
#include "src/core/ext/resolver/dns/c_ares/grpc_ares_ev_driver.h"
3940
#include "src/core/ext/resolver/dns/c_ares/grpc_ares_wrapper.h"
4041

4142
void grpc_resolve_address_ares_impl(grpc_exec_ctx *exec_ctx, const char *name,
4243
const char *default_port,
43-
grpc_ares_ev_driver *ev_driver,
44+
grpc_pollset_set *interested_parties,
4445
grpc_closure *on_done,
4546
grpc_resolved_addresses **addrs) {
46-
grpc_resolve_address(exec_ctx, name, default_port, on_done, addrs);
47+
grpc_resolve_address(exec_ctx, name, default_port, interested_parties,
48+
on_done, addrs);
4749
}
4850

4951
void (*grpc_resolve_address_ares)(
5052
grpc_exec_ctx *exec_ctx, const char *name, const char *default_port,
51-
grpc_ares_ev_driver *ev_driver, grpc_closure *on_done,
53+
grpc_pollset_set *interested_parties, grpc_closure *on_done,
5254
grpc_resolved_addresses **addrs) = grpc_resolve_address_ares_impl;
5355

5456
grpc_error *grpc_ares_init(void) { return GRPC_ERROR_NONE; }

0 commit comments

Comments
 (0)