Skip to content

Commit 09b4633

Browse files
committed
Reduce fields not necessary.
1 parent c96bdea commit 09b4633

File tree

4 files changed

+11
-20
lines changed

4 files changed

+11
-20
lines changed

jackson/src/test/java/org/baeldung/jackson/field/MyDtoGetter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public MyDtoGetter() {
99
super();
1010
}
1111

12-
public MyDtoGetter(final String stringValue, final int intValue, final boolean booleanValue) {
12+
public MyDtoGetter(final String stringValue, final int intValue) {
1313
super();
1414

1515
this.stringValue = stringValue;

jackson/src/test/java/org/baeldung/jackson/field/MyDtoGetterImplicitDeserialization.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,15 @@
33
public class MyDtoGetterImplicitDeserialization {
44

55
private String stringValue;
6-
public boolean booleanValue;
76

87
public MyDtoGetterImplicitDeserialization() {
98
super();
109
}
1110

12-
public MyDtoGetterImplicitDeserialization(final String stringValue, final int intValue, final boolean booleanValue) {
11+
public MyDtoGetterImplicitDeserialization(final String stringValue) {
1312
super();
1413

1514
this.stringValue = stringValue;
16-
this.booleanValue = booleanValue;
1715
}
1816

1917
// API

jackson/src/test/java/org/baeldung/jackson/field/MyDtoSetter.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,26 +2,22 @@
22

33
public class MyDtoSetter {
44

5-
private String stringValue;
6-
int intValue;
5+
private int intValue;
6+
public boolean booleanValue;
77

88
public MyDtoSetter() {
99
super();
1010
}
1111

12-
public MyDtoSetter(final String stringValue, final int intValue, final boolean booleanValue) {
12+
public MyDtoSetter(final int intValue, final boolean booleanValue) {
1313
super();
1414

15-
this.stringValue = stringValue;
1615
this.intValue = intValue;
16+
this.booleanValue = booleanValue;
1717
}
1818

1919
// API
2020

21-
public String getStringValue() {
22-
return stringValue;
23-
}
24-
2521
public void setIntValue(final int intValue) {
2622
this.intValue = intValue;
2723
}

jackson/src/test/java/org/baeldung/jackson/test/JacksonFieldUnitTest.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
public class JacksonFieldUnitTest {
2424

2525
@Test
26-
public final void givenDifferentAccessLevels_whenPrivateOrPackage_thenNotSerializable_whenPublic_thenSerializable() throws JsonProcessingException {
26+
public final void givenDifferentAccessLevels_whenPublic_thenSerializable() throws JsonProcessingException {
2727
final ObjectMapper mapper = new ObjectMapper();
2828

2929
final MyDtoAccessLevel dtoObject = new MyDtoAccessLevel();
@@ -49,42 +49,39 @@ public final void givenDifferentAccessLevels_whenGetterAdded_thenSerializable()
4949

5050
@Test
5151
public final void givenDifferentAccessLevels_whenGetterAdded_thenDeserializable() throws JsonProcessingException, JsonMappingException, IOException {
52-
final String jsonAsString = "{\"stringValue\":\"dtoString\",\"booleanValue\":\"true\"}";
52+
final String jsonAsString = "{\"stringValue\":\"dtoString\"}";
5353
final ObjectMapper mapper = new ObjectMapper();
5454

5555
final MyDtoGetterImplicitDeserialization dtoObject = mapper.readValue(jsonAsString, MyDtoGetterImplicitDeserialization.class);
5656

5757
assertNotNull(dtoObject);
5858
assertThat(dtoObject.getStringValue(), equalTo("dtoString"));
59-
assertThat(dtoObject.booleanValue, equalTo(true));
6059
}
6160

6261
@Test
6362
public final void givenDifferentAccessLevels_whenSetterAdded_thenDeserializable() throws JsonProcessingException, JsonMappingException, IOException {
64-
final String jsonAsString = "{\"stringValue\":\"dtoString\",\"intValue\":1}";
63+
final String jsonAsString = "{\"intValue\":1}";
6564
final ObjectMapper mapper = new ObjectMapper();
6665

6766
final MyDtoSetter dtoObject = mapper.readValue(jsonAsString, MyDtoSetter.class);
6867

6968
assertNotNull(dtoObject);
70-
assertThat(dtoObject.getStringValue(), equalTo("dtoString"));
7169
assertThat(dtoObject.anotherGetIntValue(), equalTo(1));
7270
}
7371

7472
@Test
75-
public final void givenDifferentAccessLevels_whenSetterAdded_thenStillNotSerializable() throws JsonProcessingException, JsonMappingException, IOException {
73+
public final void givenDifferentAccessLevels_whenSetterAdded_thenStillNotSerializable() throws JsonProcessingException {
7674
final ObjectMapper mapper = new ObjectMapper();
7775

7876
final MyDtoSetter dtoObject = new MyDtoSetter();
7977

8078
final String dtoAsString = mapper.writeValueAsString(dtoObject);
81-
assertThat(dtoAsString, containsString("stringValue"));
8279
assertThat(dtoAsString, not(containsString("intValue")));
8380
System.out.println(dtoAsString);
8481
}
8582

8683
@Test
87-
public final void givenDifferentAccessLevels_whenSetVisibility_thenSerializable() throws JsonProcessingException, JsonMappingException, IOException {
84+
public final void givenDifferentAccessLevels_whenSetVisibility_thenSerializable() throws JsonProcessingException {
8885
final ObjectMapper mapper = new ObjectMapper();
8986
mapper.setVisibility(PropertyAccessor.ALL, Visibility.NONE);
9087
mapper.setVisibility(PropertyAccessor.FIELD, Visibility.ANY);

0 commit comments

Comments
 (0)