Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Typos 'RyRadio' when updating #278

Closed
travis-jeans opened this issue Mar 5, 2025 · 3 comments
Closed

[BUG] Typos 'RyRadio' when updating #278

travis-jeans opened this issue Mar 5, 2025 · 3 comments

Comments

@travis-jeans
Copy link

travis-jeans commented Mar 5, 2025

Describe the bug
I noticed when updating the text will say "RyRadio" instead of "PyRadio". A grep search grep -r -i RyRadio . finds the following matches:

  • ./pyradio/install.py: print('Extracting RyRadio source code...')
  • ./pyradio/config.py: ret = "RyRadio built from git: {0} (rev. {1})".format(git_info[-1], git_info[1])
  • ./devel/README.md:RyRadio version) and commit it upstream.
  • ./docs/rec-dir.md:Up until v. 0.9.3.10, Ryradio would create the "recording directory" upon startup, no matter where it would be located, making it available for the recording and titles' log function.
  • ./docs/rec-dir.html:Up until v. 0.9.3.10, Ryradio would create the “recording directory” upon startup, no matter where it would be located, making it available for the recording and titles’ log function.

Not sure if this is intentional or not, but since I've seen it I can't unsee it.

@s-n-g
Copy link
Collaborator

s-n-g commented Mar 5, 2025

Hi @travis-jeans

Thanks for pointing out all those typos; fixed in devel

Regarding the "recording directory": yes, this is as you have noticed, the directory will be created only if the user starts a recording or starts titles logging.

If it exists at program startup and it is empty, it will be removed, if it's not empty it will not be deleted, of course

@travis-jeans
Copy link
Author

travis-jeans commented Mar 6, 2025

Hi @travis-jeans

Thanks for pointing out all those typos; fixed in devel

Thank you!

Regarding the "recording directory": yes, this is as you have noticed, the directory will be created only if the user starts a recording or starts titles logging.

If it exists at program startup and it is empty, it will be removed, if it's not empty it will not be deleted, of course

Sorry just realized the grep had found some paragraph <p> tags which wrapped around the part about the recording directory. That line was just what the search found, not something I wrote. I fixed the post so it's formatted in the list properly.

s-n-g added a commit that referenced this issue Mar 10, 2025
- fixing #279 - The list of favorite stations is reset when added
- fixing #278 - Typos 'RyRadio' when updating
- updating docs
@s-n-g
Copy link
Collaborator

s-n-g commented Mar 10, 2025

Fixed in 0.9.3.11.6

@s-n-g s-n-g closed this as completed Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants