Skip to content

Commit 066e980

Browse files
committed
refactor: set config in test
1 parent 6542075 commit 066e980

File tree

1 file changed

+9
-25
lines changed

1 file changed

+9
-25
lines changed

tests/Feature/WikiImportCommandTest.php

Lines changed: 9 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -121,15 +121,19 @@ public function testHandleShow()
121121
->assertExitCode(0);
122122
}
123123

124-
public function testHandleConfluenceHtmlDirNotExist()
124+
private function setConfig()
125125
{
126126
$codingToken = $this->faker->md5;
127127
config(['coding.token' => $codingToken]);
128128
$codingTeamDomain = $this->faker->domainWord;
129129
config(['coding.team_domain' => $codingTeamDomain]);
130130
$codingProjectUri = $this->faker->slug;
131131
config(['coding.project_uri' => $codingProjectUri]);
132+
}
132133

134+
public function testHandleConfluenceHtmlDirNotExist()
135+
{
136+
$this->setConfig();
133137
$this->artisan('wiki:import')
134138
->expectsQuestion('数据来源?', 'Confluence')
135139
->expectsQuestion('数据类型?', 'HTML')
@@ -142,12 +146,7 @@ public function testHandleConfluenceHtmlDirNotExist()
142146

143147
public function testHandleConfluenceHtmlFileNotExist()
144148
{
145-
$codingToken = $this->faker->md5;
146-
config(['coding.token' => $codingToken]);
147-
$codingTeamDomain = $this->faker->domainWord;
148-
config(['coding.team_domain' => $codingTeamDomain]);
149-
$codingProjectUri = $this->faker->slug;
150-
config(['coding.project_uri' => $codingProjectUri]);
149+
$this->setConfig();
151150

152151
$this->artisan('wiki:import')
153152
->expectsQuestion('数据来源?', 'Confluence')
@@ -159,12 +158,7 @@ public function testHandleConfluenceHtmlFileNotExist()
159158

160159
public function testHandleConfluenceHtmlSuccess()
161160
{
162-
$codingToken = $this->faker->md5;
163-
config(['coding.token' => $codingToken]);
164-
$codingTeamDomain = $this->faker->domainWord;
165-
config(['coding.team_domain' => $codingTeamDomain]);
166-
$codingProjectUri = $this->faker->slug;
167-
config(['coding.project_uri' => $codingProjectUri]);
161+
$this->setConfig();
168162

169163
// 注意:不能使用 partialMock
170164
// https://laracasts.com/discuss/channels/testing/this-partialmock-doesnt-call-the-constructor
@@ -214,12 +208,7 @@ public function testHandleConfluenceHtmlSuccess()
214208

215209
public function testAskNothing()
216210
{
217-
$codingToken = $this->faker->md5;
218-
config(['coding.token' => $codingToken]);
219-
$codingTeamDomain = $this->faker->domainWord;
220-
config(['coding.team_domain' => $codingTeamDomain]);
221-
$codingProjectUri = $this->faker->slug;
222-
config(['coding.project_uri' => $codingProjectUri]);
211+
$this->setConfig();
223212
config(['coding.import.provider' => 'Confluence']);
224213
// TODO config function can set the key not exists, can't test the key not exists in config file
225214
config(['coding.import.data_type' => 'HTML']);
@@ -231,12 +220,7 @@ public function testAskNothing()
231220

232221
public function testHandleConfluenceHtmlZipSuccess()
233222
{
234-
$codingToken = $this->faker->md5;
235-
config(['coding.token' => $codingToken]);
236-
$codingTeamDomain = $this->faker->domainWord;
237-
config(['coding.team_domain' => $codingTeamDomain]);
238-
$codingProjectUri = $this->faker->slug;
239-
config(['coding.project_uri' => $codingProjectUri]);
223+
$this->setConfig();
240224

241225
// 注意:不能使用 partialMock
242226
// https://laracasts.com/discuss/channels/testing/this-partialmock-doesnt-call-the-constructor

0 commit comments

Comments
 (0)