Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GB holidays Christmas/Boxing day (25th/26th December) - incorrect substitution rules #203

Closed
GordoRank opened this issue Feb 24, 2021 · 0 comments
Closed

GB holidays Christmas/Boxing day (25th/26th December) - incorrect substitution rules #203

GordoRank opened this issue Feb 24, 2021 · 0 comments

Comments

@GordoRank
Copy link

GordoRank commented Feb 24, 2021 •
edited
Loading

GB holidays for 2021 are substituted incorrectly due do incorrect rules.

According to date-holidays:

Christmas Day falls on 28/12/2021
Boxing Day falls on 27/12/2021

Actual dates

Christmas Day falls on 27/12/2021
Boxing Day falls on 28/12/2021

From looking at the data files, the rules of appear to be incorrect.

It should be:

When 26 December falls on a Saturday, the associated public holiday is on the following Monday. When 26 December falls on a Sunday, the public holiday is the following Tuesday, Monday being the public holiday associated with Christmas Day.[25]

 If Christmas Day (25th) === Saturday, then substitute next Monday
 If Christmas Day (25th) === Sunday, then substitute next Monday
 If Boxing Day (26th) === Saturday, then substitute next Monday
 If Boxing Day (26th) === Sunday, then substitute next Tuesday
@GordoRank GordoRank changed the title GB holidays (25th/26th) incorrect substitution rules GB holidays Christmas/Boxing day (25th/26th December) - incorrect substitution rules Feb 24, 2021
commenthol added a commit that referenced this issue Mar 31, 2021
@commenthol
fix(GB): #203 boxing day substitution rules
a90f92a
@commenthol commenthol mentioned this issue Mar 31, 2021
Merged
commenthol added a commit that referenced this issue Apr 8, 2021
@commenthol
fix(GB): #203 boxing day substitution rules
a34aff0
commenthol added a commit that referenced this issue Apr 8, 2021
@commenthol
Merge pull request #217 from commenthol/fix-gb-boxing-day
2d4bb08 
fix(GB): #203 boxing day substitution rules
commenthol added a commit that referenced this issue Apr 8, 2021
@commenthol
fix(GB): #203 boxing day substitution rules
9e805a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@commenthol @GordoRank