Skip to content

Commit 6f7bdf8

Browse files
committed
Update Sizzle: Add test for [selected] attribute selections. Addresses a small issue in IE8's boolean attribute selections with QSA.
1 parent 631f093 commit 6f7bdf8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/sizzle

Submodule sizzle updated 1 file

test/unit/selector.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ test("disconnected nodes", function() {
6262
});
6363

6464
testIframe("selector/html5_selector", "attributes - jQuery.attr", function( jQuery, window, document ) {
65-
expect(34);
65+
expect(35);
6666

6767
/**
6868
* Returns an array of elements with the given IDs, eg.
@@ -119,7 +119,7 @@ testIframe("selector/html5_selector", "attributes - jQuery.attr", function( jQue
119119
t( "Attribute Exists", "[indeterminate]", []);
120120
t( "Attribute Exists", "[ismap]", ["img1"]);
121121
t( "Attribute Exists", "[itemscope]", ["div1"]);
122-
// t( "Attribute Exists", "[loop]", ["video1"]); // IE 6/7 cannot differentiate here. loop is also used on img, input, and marquee tags as well as video/audio. getAttributeNode unfortunately only retrieves the property value.
122+
// t( "Attribute Exists", "[loop]", ["video1"]); // IE 6/7 cannot differentiate here. loop is also used on img, input, and marquee tags as well as video/audio. getAttributeNode unfortunately also retrieves the property value.
123123
t( "Attribute Exists", "[multiple]", ["select1"]);
124124
t( "Attribute Exists", "[muted]", ["audio1"]);
125125
// t( "Attribute Exists", "[nohref]", ["area1"]); // IE 6/7 keep this set to false regardless of presence. The attribute node is not retrievable.
@@ -134,7 +134,7 @@ testIframe("selector/html5_selector", "attributes - jQuery.attr", function( jQue
134134
t( "Attribute Exists", "[reversed]", ["ol1"]);
135135
t( "Attribute Exists", "[scoped]", ["style1"]);
136136
t( "Attribute Exists", "[seamless]", ["iframe1"]);
137-
// t( "Attribute Exists", "[selected]", ["option1"]); // IE8's querySelectorAll fails here. Redirecting to oldSizzle would work, but it would require an additional support test as well as a check for the selected attribute within the qsa logic
137+
t( "Attribute Exists", "[selected]", ["option1"]);
138138
t( "Attribute Exists", "[truespeed]", ["marquee1"]);
139139

140140
// Enumerated attributes (these are not boolean content attributes)

0 commit comments

Comments
 (0)