Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Implement more rigorous testing #26

Open
5 tasks
brianredbeard opened this issue Jul 6, 2016 · 2 comments
Open
5 tasks

Implement more rigorous testing #26

brianredbeard opened this issue Jul 6, 2016 · 2 comments

Comments

@brianredbeard
Copy link
Member

We should implement functional and unit testing for Mayday.

  • Unit Testing
    • Invalid command parsing
    • Symbolic link naming
  • Functional
    • File does not exist
    • File isn't readable
    • Permissions are wrong

As we progress in adding features (Object storage upload, etc) we should strive for 100% test coverage.

@tschuy
Copy link
Contributor

tschuy commented Jul 6, 2016

#27 has a bunch of setup for getting testing done, and contains tests for file.go and command.go.

Can you explain more about what we're looking for the (specific tests you pointed out) to do? For instance, for "symbolic link naming", is that just making sure that if I say to run tar -xzf foo.tar.gz and make a link called "foo", that the link foo is made to mayday_commands/tar_-xzf_foo.tar.gz ? And for the functional tests, these are tests on the output files in /tmp/, correct?

@tschuy
Copy link
Contributor

tschuy commented Jul 8, 2016

Ok, I rewrote Mayday. See #29. It's a heck of a lot more testable, but there are certain aspects I'm not sure of.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants