Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/group names can include characters that maybe should be filtered out such as quotes and more #37

Open
jkeltz opened this issue Sep 23, 2024 · 1 comment

Comments

@jkeltz
Copy link

jkeltz commented Sep 23, 2024

Issue Description

I didn't include a fix for this because I'm not sure whether this is a bug or not. Should admins really be able to include such things as quotes, etc. in usernames or group names? Probably not.. probably need to implement better checking in the future...

@jkeltz jkeltz changed the title User/group names can include characters that maybe should be filtered out User/group names can include characters that maybe should be filtered out such as quotes and more Sep 23, 2024
@einhirn
Copy link
Contributor

einhirn commented Oct 8, 2024

The user/group names are filtered through the auth-plugin's cleanUser/cleanGroup functions - if they don't throw these characters out, they'll probably be ok!? Even if one were to change the auth backend later, the cleaning happens before comparison etc. so worst case would be that someone loses access because of characters that are filtered now.

As for display of the values the plugin saved, I seem to remember that everything gets htmlspecials treatment or something like that before being sent to the browser...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants