Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2440/uni merge: issues with WC #351

Closed
Tracked by #523
anxolin opened this issue Apr 2, 2022 · 7 comments · Fixed by #444
Closed
Tracked by #523

2440/uni merge: issues with WC #351

anxolin opened this issue Apr 2, 2022 · 7 comments · Fixed by #444
Assignees
@alfetopito
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 2, 2022

Related to #2536

  1. the 2nd QR code is not generated when Try again WC connection process
    image.png
  2. When connected to WC (using 'Copy link'), wallet info is not displayed in the activity modal
    image.png

Original issue gnosis/cowswap#2641 by @elena-zh
@anxolin anxolin added Medium Severity indicator. It causes some undesirable behavior, but the system is still functional app:CowSwap CowSwap app Bug Something isn't working labels Apr 2, 2022
This was referenced Apr 4, 2022
Closed
Merged
@nenadV91
Copy link
Contributor

nenadV91 commented Apr 8, 2022

This issue is probably related to gnosis/cowswap#1929 and this should be fixed in here #360

@elena-zh
Copy link
Contributor

elena-zh commented Apr 8, 2022

@nenadV91 , the issue is related exactly to the Uni merge PR.
I assume that code in #360 does not contain changes related to #374 PR

@nenadV91
Copy link
Contributor

nenadV91 commented Apr 8, 2022 •
edited
Loading

I think it does because this UNI merge updates the @web3-react/walletconnect-connector version which is the same thing I did in that PR and then this issue happens, but its fixed in that #360 PR

@alfetopito
Copy link
Collaborator

I've debugged this a little and as far as I could tell, there was no wallet info coming from the wallet anymore, likely due to walletconnect-connect update as Nenad points out.

@anxolin
Copy link
Contributor Author

anxolin commented Apr 22, 2022

But then, after Nenas fix, it should be OK. So probably is best to rebase, retest and review #360

@elena-zh
Copy link
Contributor

Only the last part of the issue is fixed in this PR (case 1)
Case 2 is still reproducible here
safe

@elena-zh elena-zh mentioned this issue Apr 22, 2022
Merged
@alfetopito
Copy link
Collaborator

Seems to be caused by the same issue as #342

@alfetopito alfetopito self-assigned this Apr 22, 2022
@elena-zh elena-zh mentioned this issue Apr 25, 2022
Merged
@anxolin anxolin mentioned this issue May 2, 2022
Merged
@elena-zh elena-zh closed this as completed May 4, 2022
@anxolin anxolin mentioned this issue May 5, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alfetopito alfetopito

Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix walletconnect double qr code updated cowprotocol/cowswap
4 participants
@alfetopito @anxolin @nenadV91 @elena-zh