Disable color by default unless running in an interactive terminal

[nettrino]

Description

With the current defaults escape characters appear on logs in most platforms making output harder to read

[ee7]

We currently try to disable color when stdout is not a tty:

chalk/src/util.nim

Lines 299 to 300 in b70a3fa

	if isatty(1) == 0:
	setShowColor(false)

I'll check if this needs to integrate better with the config, or e.g. the environment variables:

• NO_COLOR existing
• or TERM having the value DUMB.

[viega]

If the call to `otherSetupTasks` got moved, it could be that the value is getting clobbered; since that's in Nim code, any conf file load is going to write over it. One of the things that won't be a problem when the newer con4m is merged. If NO_COLOR is on, it will always disable the color though.

…

On Tue, May 28, 2024 at 8:51 AM ee7 ***@***.***> wrote: We currently try to disable color when stdout is not a tty: https://github.com/crashappsec/chalk/blob/b70a3faa3fc88669ef1ea7417acf5592d30fb9da/src/util.nim#L299-L300 I'll check if this needs to integrate better with the config, or e.g. the environment variables: - NO_COLOR existing - or TERM having the value DUMB. — Reply to this email directly, view it on GitHub <#297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABELGQPXVT64TBQVXX7ZM4LZER4UVAVCNFSM6AAAAABIMNCPVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZVGE2DCNBUGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[miki725]

chalk/src/chalk.nim

Lines 13 to 19 in afa0934

	when isMainModule:
	setupSignalHandlers() # util.nim
	setupTerminal() # util.nim
	ioSetup() # sinks.nim
	loadAllConfigs() # confload.nim
	recursionCheck() # norecurse.nim
	otherSetupTasks() # util.nim

should be getting called last