Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tax is calculated on non discounted price #1122

Open
colognation opened this issue Dec 29, 2022 · 3 comments · May be fixed by invoice-crater/crater#4
Open

Tax is calculated on non discounted price #1122

colognation opened this issue Dec 29, 2022 · 3 comments · May be fixed by invoice-crater/crater#4

Comments

@colognation
Copy link

Describe the bug
If you have an article with discount the tax (on article level) is calculated on the non discounted price. So the tax calculated will always be to high.

It looks like the values in "app/Http/Resources/Customer/InvoiceItemResource.php" class are not correct (total, base_price, base_total). This results in the wrong calculation as the discount is not observed in these variables.

Expected behavior
Tax should be calculated on the correct discounted price (base_total).

Please complete the following information:

  • Crater version: 6.0.6
  • PHP version: 8.0
  • Database type and version: MySQL 8.0
@albertvisuals
Copy link

When will this issue be fixed? This is a huge problem, when the invoice calculates false numbers!

@albertvisuals
Copy link

Is there no response at all? In the current release the tool calculates wrong, which is a huge issue for an invoice program!

@Contributolo
Copy link

Has crater been abandoned?

@nielsdrost7 nielsdrost7 linked a pull request Jan 27, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants