Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare crater for clean docker-image #831

Open
LU-386 opened this issue Mar 8, 2022 · 2 comments
Open

prepare crater for clean docker-image #831

LU-386 opened this issue Mar 8, 2022 · 2 comments

Comments

@LU-386
Copy link

LU-386 commented Mar 8, 2022

I've already recreated parts of the docker-deployment, but there is still one improvement to make:

The current docker-image does mount the root of the repo as root of the php-application.
This is nice for development (easy access to the files) and makes updates from the webinterface easy (just override the files directly), but has many downsides for productive environment (security and permission issues, off-standard docker-images and it makes crater difficult to deploy migrate).

A perfectly designed docker-images does provide different versions based on labels and does contain anything for the application to run by itself. Persistent data should be mounted in a volume (or in a directory with a bind-mount) or should be stored in the database (which should be persistent with a volume or bind-mount). It is getting configured by environment-variables, docker-secrets and/or a single config-file to mount from the host

For crater that would mean: run crater, ofelia and mariadb (for example) and any reverse-proxy with standard-containers and only have deployment-depended information in some directories of crater which are mounted to the host and the database.

To which directories does crater write information and could we achieve that we only use some directories for that?

(at the moment I think the env-file [which could be replaced by env in docker-compose.yml or Dockerfile], modules, custom templating and [wherever this is set] the flag to mark that crater has already been set up)

@gromain
Copy link

gromain commented Aug 4, 2022

Seconding this request, this would be a great improvement

@toubul
Copy link

toubul commented Jan 10, 2023

Here to ask if there is any progress with that ?:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants