Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please cross-reference license somewhere #15

Closed
QuLogic opened this issue Nov 21, 2019 · 4 comments
Closed

Please cross-reference license somewhere #15

QuLogic opened this issue Nov 21, 2019 · 4 comments

Comments

@QuLogic
Copy link

QuLogic commented Nov 21, 2019

Because my reviewer really wants this to happen, please add a note of the license in the readme/sources.

@creack
Copy link
Owner

creack commented Nov 21, 2019

I'm not really sure to understand what you are asking. Would you have an example of an other MIT repository that would comply with the reviewer's request?

Adding MIT mentions on every file seems overkill. I can add something to the Readme, but not sure what.

@QuLogic
Copy link
Author

QuLogic commented Nov 25, 2019

Well, the reviewer said:

Upstream needs to clarify this somehow, because it's not clear at the moment.
The best way to do this is to add a comment in the actual source files.
If there's any reason upstream has to object this, they could do something else, such as adding a statement in the README file.

There's might be a chance that "this software" in the MIT license text could be understood as referring to whatever is in the same directory or tarball, but I don't know whether that's universally understood and would prefer a clarification to guessing.

though I agree with you and think adding it to all files is excessive. I suggest just adding a short bit in the readme, like minify or parse.

@creack
Copy link
Owner

creack commented Nov 25, 2019

Done on v0.1.1

@creack creack closed this as completed Nov 25, 2019
@QuLogic
Copy link
Author

QuLogic commented Nov 26, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants