Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New type in 2.0.39 breaks createGlobalStyles funcs #347

Closed
mikestopcontinues opened this issue Jul 10, 2021 · 2 comments
Closed

New type in 2.0.39 breaks createGlobalStyles funcs #347

mikestopcontinues opened this issue Jul 10, 2021 · 2 comments

Comments

@mikestopcontinues
Copy link

This line now says that (props: Theme<DefaultTheme>), rather than (props: {theme: Theme<DefaultTheme>}).
@jlalmes
Copy link
Contributor

jlalmes commented Jul 11, 2021

Hi @mikestopcontinues (props: Theme<DefaultTheme>) is the correct type. Please see the Theme type implementation here: https://github.com/cristianbote/goober/blob/master/goober.d.ts#L10

@mikestopcontinues
Copy link
Author

Thanks @jlalmes, my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikestopcontinues @jlalmes