-
-
Notifications
You must be signed in to change notification settings - Fork 141
Adding images requires file extensions #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Unfortunately the APIs require a MIME type to work properly, and we're inferring that from the extension. We could expose the a way to set the MIME type manually, wdyt? |
Yeah that would be sufficient for my needs. |
@tpaulshippy do you have an example URL for me? I'm implementing the tests |
@tpaulshippy just rewrote the whole content and attachment system to be a lot simpler and not needing to specify mime types manually: fb5e4e4 will work on the rails integration tomorrow |
And I just got it working haha. It's ok - should be easy to switch. Thanks! |
Pushed 53fca94 |
Uh oh!
There was an error while loading. Please reload this page.
When I run this:
if my URL does not end in
.jpg
I am unable to make it work. I was able to workaround this by saving the image to a temp file and naming it with the .jpg extension.It seems like if I know the image type, I should be able to provide it to the library and skip the
detect_from_path
method entirely.The text was updated successfully, but these errors were encountered: